search

unclechu / node-deep-extend

Recursive extend module
MIT License
202 stars 53 forks source link

Buffer with browserify #9

Closed gagan-bansal closed 9 years ago

gagan-bansal commented 10 years ago

No doubt Buffer support is good addition to this module. But I was using deep-extend with browserify. After including the Buffer, browserify output increases by ~30kb. Is there any work around to avoid Buffer inclusion while browserify the deep-extend as my application doesn't require Buffer support ?

unclechu commented 10 years ago

I never imagined that it will be used in browser. It uses .isArray() and .forEach methods of Array, that doesn't supports by some versions of evil corporation browser. There's more cross-browser deep-extend in jQuery for example.

I think if you really need use this in browser I can create gulp-tasks for build this module more cross-browserly and without Buffer.

gagan-bansal commented 10 years ago

In the mean time I found one more module xtend. Seems equally good for my requirement. You can through some more light comparing these two, that would be good for the users.