unclesp1d3r / CipherSwarm

CipherSwarm is a distributed hash cracking system designed for efficiency and scalability, built on Ruby on Rails.
Mozilla Public License 2.0
2 stars 0 forks source link

Completed campaigns are included in the maximum priority calculations #189

Open unclesp1d3r opened 1 month ago

unclesp1d3r commented 1 month ago

When the method is being triggered to pause all campaigns but the highest priorities, the query includes completed campaigns of higher priorities, so there will be times when all available campaigns are paused because it thinks that there is a higher priority, even if that higher priority is just on completed campaigns.

unclesp1d3r commented 1 month ago

From CoPilot:

Issue #189 states that the method responsible for pausing all campaigns except the highest priority ones is incorrectly including completed campaigns in its calculations. This can lead to situations where all available campaigns are paused because the system mistakenly thinks there is a higher-priority campaign, even if it is already completed.

To address this, you need to ensure that the calculation method in the Campaign model correctly excludes completed campaigns when determining the highest priority campaigns to pause. You can find the relevant logic in the pause method and associated priority management code in the Campaign model file.