search

uncodead / BrewUNO

High precision and accuracy, open source, online, extensible and low cost homebrew automation on top of ESP8266 microchip.
http://www.brewuno.com
Other
91 stars 44 forks source link

Add Config-Switch "PASSIVE_BUZZER" #86

Open der-tommy opened 3 years ago

der-tommy commented 3 years ago

Add Config-Switch "PASSIVE_BUZZER" for changing between active or passive buzzer/piezo

uncodead commented 3 years ago

Did you make modifications on platformio.ini?

der-tommy commented 3 years ago

Hi Bruno,

when not setting this config-switch in platform.ini BrewUno works as it was initially set up. When setting it, it creates the tone() for a passive buzzer/piezo.

So there is no need to change the platform.ini for that. But I could add it there and comment in out (default behaviour). How is the project handling other optional “ifdef” in platform.ini?

Kind regards

der-tommy commented 3 years ago

can you please complete this PR or is there ay todo from my site?

uncodead commented 2 years ago

does this PR still make sense?

der-tommy commented 2 years ago

yes it makes sense in my opinion. There are electrical active or passive buzzer which you can buy. Then you could easily build your device with both types.