Occurences of 'innerText' were replaced with 'textContent'

unconed / MathBox.js

MathBox is a (work in progress) library for making presentation-quality math diagrams in WebGL.

MIT License

1.94k stars 127 forks source link

Occurences of 'innerText' were replaced with 'textContent' #24

Closed EvgenyAgafonchikov closed 10 years ago

EvgenyAgafonchikov commented 10 years ago

Occurences of 'innerText' were replaced with 'textContent' for all files excluding external libraries. This fix improves compatibility with IE11 by utilizing “textContent”, a W3C standard API. innerText logic handles newlines differently in different browsers, which can cause shader compilation problems.

ghost commented 10 years ago

@unconed - i know from the discussion in #21 that you are currently rewriting the library and this branch is eventually going to be deprecated. Just to confirm my expectations: do you expect to perform any additional merges in the current branch (and to review this pull request as part of it)? Thanks.

unconed commented 10 years ago

Sure, I've just been busy the past few weeks. Bugfixes can definitely go in, I'm still using the library too.

TextContent works in all the browsers I care about, so this seems legit.

ghost commented 10 years ago

Thanks!