unconed / mathbox

Presentation-quality WebGL math graphing
MIT License
1.33k stars 109 forks source link

fix gridlines on filled surfaces #27

Closed ChristopherChudzicki closed 2 years ago

ChristopherChudzicki commented 2 years ago

Is there a related issue? #25

#25 is mostly about shaded surfaces being too dark, but we also noticed a gridline issue there, too.

What does this PR do?

In #25 we noted that recent versions of mathbox (including znah's ThreeJS r84 fork) have black gridlines. This fixes that issue.

v0.0.5 Gridlines exactly same color as surface, so not visible unless surface is shaded. From the code in 0.0.5 it's clear the intent was to darken the gridlines, but this appears not to have been working in 0.0.5

Screen Shot 2022-04-13 at 6 23 40 PM

v2.1.3 Black gridlines in all cases. Also darker shaded surface; see #26

Screen Shot 2022-04-13 at 6 20 38 PM

This branch Gridlines of proper color; darker surface will be fixed by #26

Screen Shot 2022-04-13 at 6 17 41 PM