search

unconed / mathbox

Presentation-quality WebGL math graphing
MIT License
1.33k stars 109 forks source link

add new types for latch, reveal, etc #34

Closed ChristopherChudzicki closed 2 years ago

ChristopherChudzicki commented 2 years ago

This is a followup to https://github.com/unconed/mathbox/pull/32, adding typescript definitions for those changes

ChristopherChudzicki commented 2 years ago

@sritchie I forgot i did not merge this. Anyway... feel free to review/merge, otherwise I will this weekend.

I'm also happy to put together a new release, or you can.

sritchie commented 2 years ago

Looks good to me.

Question: should we make these two files our first typescript files, and put the types directly in with the new code?

sritchie commented 2 years ago

Looks good to me.

Question: should we make these two files our first typescript files, and put the types directly in with the new code?

ChristopherChudzicki commented 2 years ago

Question: should we make these two files our first typescript files, and put the types directly in with the new code?

"These two" being latch.js and reveal.js? I don't think so... If we did, we'd get a lot of anys from the dependencies. I think if we want to convert stuff to ts, the place to start is Model. But, that's just my 2c