search

unconed / mathbox

Presentation-quality WebGL math graphing
MIT License
1.33k stars 109 forks source link

simplify threejs imports #53

Closed ChristopherChudzicki closed 1 year ago

ChristopherChudzicki commented 1 year ago

This PR simplifies the "three" imports as discussed in #49.

Do not merge: Until Threestrap v0.5.1 is published. Oh, the CI tests should fail until then anyway.

sritchie commented 1 year ago

Great work, I'll get all these reviewed and merged this morning. It was really nice to see the bundle size improvements!

sritchie commented 1 year ago

As you say, it looks like the failures come from no threestrap 0.5.1 yet. I'm excited to get publishing automated here...

Thanks for undoing my unintentionally-destructive work here!!

sritchie commented 1 year ago

(Merge away when threestrap's published)

ChristopherChudzicki commented 1 year ago

@sritchie Thanks for the reviews! PR for the instanceof of change will be a bit later today, I hope.