uncopenweb / torongo

Utilities for using Mongo with Tornado.
6 stars 1 forks source link

Managed to authenticate as undefined #7

Closed parente closed 14 years ago

parente commented 14 years ago

Only happened once, the first time I brought up a UOW server, went to the catalog, clicked login, the login popup appeared, the popup disappeared (because I had given google my permission in the past), the login deferred reported success, but my user info came back with all undefined fields and role of "anonymous". I tried uow.getUser() immediately after this happend and got the same info.

So somehow, the triggerLogin method indicated success but was missing the user info or the login actually failed.

gbishop commented 14 years ago

Ah, this must be what Charna at the center did. Look in your logs. I think you can see the response from Google. Somehow the response must have been different than expected.

gbishop commented 14 years ago

I see we are way behind on tornado updates and I see discussion of a similar sounding problem here: http://groups.google.com/group/python-tornado/browse_thread/thread/4e9db1e1cfb0c472/f0aef08a67204235?#f0aef08a67204235, perhaps we just need to update.

gbishop commented 14 years ago

I'm going to add a test to _on_auth in access.py. Currently it tests that user is not empty. I'm going to additionally test for an email address before signaling OK on the login. At least the login will fail if this case happens again.

parente commented 14 years ago

I haven't seen this in a while. Can we close?

gbishop commented 14 years ago

yes, this is fixed.