uncscode / particula

a simple, fast, and powerful particle simulator
https://uncscode.github.io/particula
MIT License
5 stars 9 forks source link

Added sweep and prune collision detection #412

Closed Gorkowski closed 9 months ago

Gorkowski commented 9 months ago
github-actions[bot] commented 9 months ago

PR Preview Action v1.4.4 :---: :rocket: Deployed preview to https://uncscode.github.io/particula/pr-preview/pr-412/ on branch gh-pages at 2023-12-04 00:38 UTC

Gorkowski commented 9 months ago

@ngmahfouz

I don't have a test for the function particle_pairs.full_sweep_and_prune_simplified, It needs some logic fixing before it can replace the manual loop of paritcle_pairs.full_sweep_and_prune

I was going to push that for the future unless the problem/solution jumps out at you.

ngmahfouz commented 9 months ago

Looks good; you should set the automerge thing on :)