search

uncscode / particula

a simple, fast, and powerful particle simulator
https://uncscode.github.io/particula
MIT License
5 stars 7 forks source link

Revisions outline #439

Closed Gorkowski closed 4 months ago

Gorkowski commented 4 months ago

Fixes #438

Discussions and examples of how we could revise the code, base.

github-actions[bot] commented 4 months ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://uncscode.github.io/particula/pr-preview/pr-439/ on branch gh-pages at 2024-03-21 18:37 UTC

Gorkowski commented 4 months ago

@ngmahfouz Check out the examples on the docs, https://uncscode.github.io/particula/pr-preview/pr-439/documentation/base/gas.html

I think this structure/framework will be pretty flexible. I'm mainly trying to layout the interactions between each class/process. What are your thoughts? You want to discuss, before proceeding?

ngmahfouz commented 4 months ago

This started with "chat with gpt on how this could work" and then went bananas 😸

We will discuss tomorrow.

One quick comment after glancing over this: I think we might benefit from utilizing the __repr__ method somewhere in this rewrite.

ngmahfouz commented 4 months ago

I notice we have no more units around. Should we drop carrying units and do everything in the 7 SI base units or possibly the 29 (or so?) base and derived units?

ngmahfouz commented 4 months ago

@Gorkowski Sorry... I got distracted. Could we rename base to something like dev or exp or experimental or next or something like that to convey that it is the next planned structure? Other than that, all other items can be delayed until later. Sorry!