search

und3f / anyevent-ping

Asynchronous ping with AnyEvent
2 stars 4 forks source link

CPAN Pull request challenge update test suite #7

Closed sdeseille closed 9 years ago

sdeseille commented 9 years ago

Hi Sergii

I joined the "CPAN Pull Request Challenge" and Neil Bowers ask me to make a Pull Request on your module "AnyEvent::Ping".

I work on Win32 system and see that test suite have some errors.

Will you accept that i submit a patch in order to the test suite work also on Win32 system ? I already found what i have to modify.

regards

sdeseille

und3f commented 9 years ago

Hi Sebastien

Yes, I will accept a patch.

I didn't investigate problem with Win32, I just think that some socket magic needed to run module under Win32 (as the raw socket is used). Anyway it is up to you, I'll wait for a patch.

Thank you for choosing AE::Ping!

und3f commented 9 years ago

CPAN testers reports about passed tests on Win32.