und3f / mojox-redis

asynchronous Redis client based on Mojo

https://metacpan.org/pod/MojoX::Redis

Artistic License 2.0

10 stars 2 forks source link

Failing due to change in Mojo::IOLoop #5

Closed tvmaly closed 12 years ago

tvmaly commented 12 years ago

Changes in Mojolicious version 2.27 are causing a failure of the tests and causing a failure to install

2.27 2011-11-16

Deprecated Mojo::IOLoop->connect in favor of Mojo::IOLoop->client.
Deprecated Mojo::IOLoop->listen in favor of Mojo::IOLoop->server.

t/redis.t ............. 1/10 Can't locate object method "listen" via package "Mojo::IOLoop" at t/redis.t line 42.

Looks like you planned 10 tests but ran 2.

Test Summary Report

t/redis.t (Wstat: 7424 Tests: 2 Failed: 0) Non-zero exit status: 29 Parse errors: Bad plan. You planned 10 tests but ran 2. Files=5, Tests=2, 1 wallclock secs ( 0.11 usr 0.02 sys + 1.50 cusr 0.10 csys = 1.73 CPU) Result: FAIL Failed 1/5 test programs. 0/2 subtests failed. make: *\ [test_dynamic] Error 255 UNDEF/MojoX-Redis-0.83.tar.gz /usr/bin/make test -- NOT OK

und3f commented 12 years ago

Hello.

Thanks for report, seems @kraih changed API again. Sorry, but now I am busy and don't have time for experiments of Mojolicious team.

tvmaly commented 12 years ago

Sergey, I understand. I often wonder if the api to Mojolicious will ever be stable. I ended up using the RedisDB module as it supports the latest lua scripting via EVAL. But your module gave me a lot of good ideas.

Best regards,

Tyson

On Sun, Apr 1, 2012 at 10:46 AM, Sergey Zasenko < reply@reply.github.com

wrote:

Hello.

Thanks for report, seems @kraih changed API again. Sorry, but now I am busy and don't have time for experiments of Mojolicious team.

Reply to this email directly or view it on GitHub: https://github.com/und3f/mojox-redis/issues/5#issuecomment-4866702

und3f commented 12 years ago

Thanks for understanding.

P.S. Mojolicious usually means that your project is legacy code http://irclog.perlgeek.de/mojo/2012-03-02#i_5238439

kraih commented 12 years ago

The MojoX:: namespace implies abandonware since it has been deprecated a few years ago, as is the case here. Our deprecation policies are outlined at http://mojolicio.us/perldoc/Mojolicious/Guides/CodingGuidelines#RULES. You're welcome to suggest improvements should you disagree with them.

und3f commented 12 years ago

@kraih, the only suggestion I have is for web-developers: "Mojolicious is fun experiment that is not so funny in production". On practice I have to update my project's code once in 1-2 months just to use latest Mojolicious. And I am not the only developer with a such problem. Actually it is a problem of any developer that uses Mojolicious. Again, I am talking about practical usage, not theoretical standards you've mentioned above.

It is my point of view and I hope you will take it adequately.

kraih commented 12 years ago

Those aren't "theoretical standards", we take the deprecation policy very serious, and looking though the issue tracker i can't find a single bug report from you regarding backcompat problems. If you refuse to be contructive there is not much i can do either i'm afraid.

und3f commented 12 years ago

@kraih don't afraid, I have found a better tools. If you don't have issue-related information, please stop off topic.

und3f commented 12 years ago

Good new, everyone!

@marcusramberg fixed the issue. Version 0.84 uploaded to CPAN.