search

undark-lab / swyft

A system for scientific simulation-based inference at scale.
Other
154 stars 13 forks source link

incorrect loss for picking best network #100

Closed bkmi closed 2 years ago

bkmi commented 2 years ago

https://github.com/undark-lab/swyft/blob/3e9935ddb14b87d8b2e36d6f99a7c15116f5a336/swyft/inference/marginalratioestimator.py#L255

I think the average loss is better than the loss on the last batch.