search

undark-lab / swyft

A system for scientific simulation-based inference at scale.
Other
154 stars 13 forks source link

Add support for pytorch-lightning 2.0.0 #119

Open cweniger opened 1 year ago

cweniger commented 1 year ago

Currently Swyft crashes with PL 2.0.0. Swyft should be updated without breaking backward compatibility with PL 1.9.0 and earlier.

cweniger commented 1 year ago

Even after the above merge there are issues when running "infer" with lightning 2.0.0, because of some incomplete limitations of the CombinedLoader in 2.0.0. This probably will solve itself over time as 2.x.x becomes more stable. For now the recommendation will be to stick to 1.9.x.

cweniger commented 10 months ago

Recent discussions in pl here:

But it still looks like it will not solve all problems (predict loop is not touched).

cweniger commented 10 months ago

Solution strategy: Write custom CombinedLoader within swyft. Might also be useful for #133