undark-lab / swyft

A system for scientific simulation-based inference at scale.
Other
161 stars 14 forks source link

Double check for head, type, second should be tail #79

Closed CHBKoenders closed 3 years ago

CHBKoenders commented 3 years ago

I believe the following line should have head replaced with tail, otherwise an initialized tail will always be saved as uninitialized.

https://github.com/undark-lab/swyft/blob/8a6d53e347b2dc5219348e2ebb414856f88cb50a/swyft/inference/ratios.py#L55

bkmi commented 3 years ago

thanks for pointing this out, but we are in the process of removing the head and tail distinction (see the simplify branch) so I think the point is moot.