search

undera / perfmon-agent

Server metrics fetching agent, based on SIGAR
Apache License 2.0
397 stars 138 forks source link

Possibility to extend perfmon-agent easily #1

Closed Hi-Fi closed 11 years ago

Hi-Fi commented 11 years ago

One suggestion how this could be achieved. Used idea from: http://docs.oracle.com/javase/tutorial/ext/basics/spi.html.

undera commented 11 years ago

Could you please delete files and folders starting with dot first? Also your code must be covered with unit tests according to project quality policy: http://jmeter-plugins.org/wiki/DeveloperGuide/

Please, correct this and let me know

Hi-Fi commented 11 years ago

I'll do those deletions and new unit tests. Sorry I just put "draft" to know if this is good way to do improvement. I just checked that old tests are passing to verify the main functionality (for some reason CI computer failed same tests I thought were working).

undera commented 11 years ago

It's OK, just keep improving it.

Hi-Fi commented 11 years ago

Not working, because build isn't including resource-files.

Should project dir-structure change to standard maven way (I'll prefer this) or add parameters to pom to get resources from another place?

undera commented 11 years ago

Maven have options in POM file to include resources into artifact.

Also, please, beware that perfmon-agent is built using java 1.4 for compatibility reasons. So don't use java 1.4 incompatible code.

Hi-Fi commented 11 years ago

Annotations need java 1.5, and mocks need those. Can't java be put to that (or 1.6/7)?

undera commented 11 years ago

No, we can't update Java for perfmon agent, since it used to gather metrics from legacy servers. We've already met this problem some time ago, when updated perfmon caused many user complains.

Hi-Fi commented 11 years ago

OK, code itself works with 1.4, tests needs to be rethinked.