search

undera / pylgbst

Python library for LEGO® PoweredUp devices
MIT License
554 stars 121 forks source link

Support Bleak 0.8+ #92

Closed antoinechauveau closed 3 years ago

antoinechauveau commented 3 years ago

Bleak 0.8 introduced a breaking API change, the constructor for class BleakClient does not take an asyncio event loop as parameter anymore.

This PR fixes #89. Note that it does not attempt to keep support for older releases of Bleak.

undera commented 3 years ago

Can you make a pull from original repo, where I fixed the cairo issue?

antoinechauveau commented 3 years ago

Andrey, any comment about the updated PR? Automated coverage checks don't like it, but I don't think I'm ready to start writing tests for this already uncovered code path.

undera commented 3 years ago

Sorry, I didn't see the update until your comment. It looks ok! Thanks for contributing!

antoinechauveau commented 3 years ago

Thank you! Sorry if I failed to give a notification about the update.