Add team support in further_review.yml files

underarmour / further-review

Pull request process enforcer.

Other

18 stars 4 forks source link

Add team support in further_review.yml files #130

Closed CKarper closed 6 years ago

CKarper commented 7 years ago

I am not familiar enough with sinon to quickly write tests for this, so it won't pass muster just yet... Feel free to edit this PR, or give me feedback on what you'd like to see changed.

Fixes #2

further-review-bot commented 7 years ago

Further Review Needed

Repo Collaborators

@kjvalencik
@paultyng

1 sign-off required

To sign-off on a PR once you are mentioned, leave a comment with LGTM, :+1: or :ship_it:.

This comment was left by the Further Review PR review app.

mbukosky commented 7 years ago

@CKarper if you don't mind, I might pick this PR up and complete the unit tests. This would be a nice feature to have.

CKarper commented 7 years ago

That would be great! I just haven't had time to revisit this, and it's a feature that could make life easier for lots of people.

I believe it's not working as-is, but I needed the tests to diagnose it.