underarmour / further-review

Pull request process enforcer.
Other
18 stars 4 forks source link

Force push on approved PR doesn't invalidate FurtherReview #251

Closed jaumann closed 7 years ago

jaumann commented 7 years ago

If a PR is approved via FurtherReview, but the PR is not merged yet, if the committer squashes and force pushes a change to the code base, the Further Review is not invalidated.

Steps to Reproduce

1) Open PR 2) Fully approve per Further Review 3) Squash and force push a change to the source branch of the PR 4) Notice that the PR is still approved and able to be merged

kjvalencik commented 7 years ago

Duplicate of https://github.com/underarmour/further-review/issues/34