search

underarmour / further-review

Pull request process enforcer.
Other
18 stars 4 forks source link

Fixed a null reference bug #255

Closed mbukosky closed 7 years ago

mbukosky commented 7 years ago

I am not 100% sure of the root cause of this issue but this is something that we see everyday. Maybe it is caused from our version of Github? But either way, we commonly see that the state object is null, which leads to a exception.

For reference, here is an example of the exception. I have had this patched for a few months now, but want to give back incase others are having the same issue.

2017-10-02T15:17:10.712364042Z TypeError: Cannot match against 'undefined' or 'null'.
2017-10-02T15:17:10.712376482Z     at /usr/src/app/lib/reviewer.js:163:17
2017-10-02T15:17:10.712379908Z     at Array.filter (native)
2017-10-02T15:17:10.71238277Z     at Reviewer.<anonymous> (/usr/src/app/lib/reviewer.js:163:10)
2017-10-02T15:17:10.712386245Z     at Generator.next (<anonymous>)
2017-10-02T15:17:10.71238936Z     at step (/usr/src/app/lib/reviewer.js:28:191)
2017-10-02T15:17:10.71239204Z     at /usr/src/app/lib/reviewer.js:28:361
2017-10-02T15:17:10.712394732Z     at process._tickDomainCallback (internal/process/next_tick.js:135:7)
coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 85.714% when pulling f60a036bed91cee9494f73bcbb2f924749a1de3e on mbukosky:null-ref-fix into 28a380545736c5d560e9a82c47a30e1b3d201405 on underarmour:master.

kjvalencik commented 7 years ago

Thanks for the PR!