search

underarmour / further-review

Pull request process enforcer.
Other
18 stars 4 forks source link

Link should be lowercase #256

Closed mbukosky closed 7 years ago

mbukosky commented 7 years ago

This one is hard to prove but we ran into issues with a long review on a PR. The link logic didn't pick up the next page because the res header was a lowercase link. I can't find direct documentation of this but I was able to replicate it with a PR after adding a bunch of junk comments.

I tested with the new API - https://developer.github.com/v3/pulls/reviews/

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 85.714% when pulling 67c2a4de1ad4646513d67504c0dcdb612dd55c52 on mbukosky:link-bug into 32825243287c606a18e818d6f1550683bce2e63b on underarmour:master.