underbent / slashdiablo-maphack

A customized maphack for the slashdiablo D2 server
49 stars 89 forks source link

[Character Stats] Faster Run/Walk does not account for barb Increased Speed #1

Open daniellasry opened 12 years ago

daniellasry commented 12 years ago

In the "Character Stats" window under "Faster Run/Walk": The value displayed does not include the bonus from the "Increased Speed" barb skill.

To repro: just get a barb with increased speed. Only the Faster Run/Walk from boots will be displayed.

underbent commented 12 years ago

Yes, this is currently a limitation of the stats screen. The game client provides an API to determine these numbers for the character, and that's exactly what we show on the screen. Apparently the numbers sometimes include skill contributions (for example, the resistance numbers do factor in a barb's Natural Resistance), but sometimes they don't. Basically, LCS syndrome.

To fix this properly, we'd have to maintain tables of skills and their contributions to these stats (not just Increased Speed, but also Vigor, and probably skills like Fanaticism that affect other stats, etc), including skill levels well over 20 which are generally not documented anywhere. And we'd have to then reproduce whatever calculations the game does internally. It's a pretty big can of worms. So don't hold your breath for this :)