search

undercover-el / undercover.el

A test coverage library for Emacs
MIT License
86 stars 14 forks source link

Add Makefile for build #24

Closed nlamirault closed 4 years ago

nlamirault commented 7 years ago

Signed-off-by: Nicolas Lamirault nicolas.lamirault@gmail.com

nlamirault commented 7 years ago

I've got an error launching unit tests : 

$ make test
Running tests on Emacs 25.1.1
..Test test-3/functions-are-covered backtrace:

  (if (unwind-protect (setq value-38 (apply fn-36 args-37)) (setq form
  (let (form-description-40) (if (unwind-protect (setq value-38 (apply
  (let ((value-38 (quote ert-form-evaluation-aborted-39))) (let (form-
  (let ((fn-36 (function get)) (args-37 (list (quote distance) (quote
  (closure (t) nil (let ((fn-36 (function get)) (args-37 (list (quote
  ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
  ert-run-test([cl-struct-ert-test test-3/functions-are-covered nil (c
  ert-run-or-rerun-test([cl-struct-ert--stats (and t) [[cl-struct-ert-
  ert-run-tests((and t) (lambda (event-type &rest event-args) (cond ((
  ert-runner/run-tests-batch((and t))
(let ((stats (ert-runner/run-tests-batch selector))) (kill-emacs (if
  ert-runner/run-tests-batch-and-exit((and t))
  (if ert-runner-verbose (ert-runner/run-tests-batch-and-exit ert-runn
  (let ((test-files (ert-runner--test-files tests)) (test-helper (f-ex
  ert-runner/run()
  apply(ert-runner/run nil)
  commander--handle-command(nil)
  commander-parse(nil)
  (if commander-parsing-done nil (commander-parse (or commander-args (
  eval-buffer(#<buffer  *load*> nil "/tmp/undercover.el/.cask/25.1/elp
  load-with-code-conversion("/tmp/undercover.el/.cask/25.1/elpa/ert-ru
  load("/tmp/undercover.el/.cask/25.1/elpa/ert-runner-20161027.159/ert
  command-line-1(("-scriptload" "/tmp/undercover.el/.cask/25.1/elpa/er
  command-line()
  normal-top-level()

[...]

Ran 8 tests in 1.553 seconds
3 unexpected results:
   FAILED  test-3/functions-are-covered
   FAILED  test-5/check-coverage-statistics
   FAILED  test-7/check-coveralls-report
make: *** [Makefile:68: test] Error 1

Any idea ?

sviridov commented 7 years ago

@nlamirault undercover.el doesn't support test coverage for byte-compiled files

CyberShadow commented 4 years ago

All the targets here seem to be wrappers around rather trivial actions that are not unreasonable to run directly from a shell prompt, so I don't see much point in this as it is. The colors seem especially excessive IMO.

Let's close this for now, until we have good arguments in favor of a makefile.