search

undercover-el / undercover.el

A test coverage library for Emacs
MIT License
86 stars 14 forks source link

Use undercover inside docker. #33

Closed AfsmNGhr closed 5 years ago

AfsmNGhr commented 7 years ago

I'm using emacs inside the docker container.

Travis CI (public)

    environment:
      - TRAVIS=$TRAVIS
      - TRAVIS_JOB_ID=$TRAVIS_JOB_ID
emacs_1  | TRAVIS=true
emacs_1  | TRAVIS_JOB_ID=271794541
emacs_1  | Sending: report to coveralls.io
emacs_1  | Sending: OK

Travis CI (with encrypt token)

    environment:
      - COVERALLS_REPO_TOKEN=$COVERALLS_REPO_TOKEN
emacs_1  | COVERALLS_REPO_TOKEN=[secure]
emacs_1  | Sending: report to coveralls.io
emacs_1  | Sending: OK

Travis CI (with raw token)

emacs_1  | Sending: report to coveralls.io
emacs_1  | Sending: OK

How fix it?

sviridov commented 7 years ago

Hi @AfsmNGhr,

I'm sorry but I'm afraid I don't understand the issue.

OK, build not found. Ok, build present, but not security.

What is OK? Which build found (or not found)? Are you talking about Coveralls build page? Could you please provide a bit more detailed explanation of the issue?

AfsmNGhr commented 7 years ago

Yes, i'm talk about Coveralls build page. Did not found current build after send. Found build on page only undercover with raw token (COVERALLS_REPO_TOKEN). There's been no mistakes. So, what do you think happened here?

sviridov commented 7 years ago

So,

Travis CI (with encrypt token)

If this way doesn't work it means that Emacs is unable to get COVERALLS_REPO_TOKEN as an environment variable (or value of it is incorrect). Nothing can be done on undercover.el side here.

Travis CI (public)

That is actually really strange. I'm not sure, maybe Coveralls was not able to extract information based on TRAVIS_JOB_ID or maybe it was a temporary issue with Coveralls... Are you able to reproduce it?

I will look into it more on weekends.

sviridov commented 7 years ago

It looks like link to environment variables for the second case (Travis CI with encrypt token) is incorrect. I cannot find this line in the log:

emacs_1 | COVERALLS_REPO_TOKEN=[secure]

I'm sorry, but I don't have time to actively debug this issue. If you really want to fix it, I would recommend you to fork undercover.el and remove shut-up call around curl request to see coveralls response. Maybe it would clarify the issue.

Sorry for not being really useful.

AfsmNGhr commented 5 years ago

Hi, @sviridov,

I decided to test undercover.el again. Caught a new warning and fix it. Now I use byte-compile-file after tangling org file.

Tested both options through travis public api and with token. Both works but when I used token for send report to it was associated HEAD instead master.

I don't know what changes made it work, as everything has changed a lot during this time.

sviridov commented 5 years ago

Hi @AfsmNGhr, great to hear that it works!