search

undercover-el / undercover.el

A test coverage library for Emacs
MIT License
86 stars 14 forks source link

Add Codecov support #39

Closed xendk closed 6 years ago

xendk commented 6 years ago

Closes #34 as discussed.

One could make an argument for making the :service option madetory, likely with a better syntax, but that would be a backwards compatibility breaking change.

sviridov commented 6 years ago

Hi @xendk! Sorry, somehow I missed this PR:(

May I ask you to do a small change and rename :service to :report-type? I think more general parameter name will be good in case if we will support something like text reports on a local machine.

but that would be a backwards compatibility breaking change.

Agree, no need to introduce breaking changes.

xendk commented 6 years ago

@sviridov Done. Though it is a bit odd that setting :report-type suppresses uploading. OTOH, it leaves :service if someone wants to implement uploaders to other services.

sviridov commented 6 years ago

Thank you, merged!

CyberShadow commented 5 years ago

It is super confusing that the :report-type option has nothing to do with undercover--determine-report-type and the report-type parameter to undercover-report.

CyberShadow commented 5 years ago

Even more confusing: :report-type does two things (setting the report path and disabling report uploading), none of which have anything to do with the actual report type.

Sorry, but this is bad.