Implement support for parallel builds

undercover-el / undercover.el

A test coverage library for Emacs

MIT License

86 stars 14 forks source link

Implement support for parallel builds #48

Closed CyberShadow closed 4 years ago

CyberShadow commented 4 years ago

~~Untested.~~

Seems to work: https://coveralls.io/builds/26943546

sviridov commented 4 years ago

Hi @CyberShadow, thank you for opening all these pull requests! Unfortunately, I have no interest in maintaining this project, so I would happily pass this duty to somebody else. It looks like you made yourself quite familiar with the codebase so far. Are you interested in becoming a maintainer of this project?

CyberShadow commented 4 years ago

Sure.

We use undercover.el in https://github.com/Emacs-D-Mode-Maintainers/Emacs-D-Mode, which I'm maintaining.

sviridov commented 4 years ago

Great news, thank you!

I'm not sure what is the best process to pass maintainer role on Github, so I suggest following plan:

You create a fork of this repository (if you want it to be different from CyberShadow/undercover.el.)
I add mention of it to the README file in my version of the repo.
We update the link to the repo in Melpa https://github.com/melpa/melpa/blob/master/recipes/undercover.

Does this plan sound good for you?

CyberShadow commented 4 years ago

Hi,

We could do that, though may I suggest one of the following:

Just add me as a collaborator. Then I'll be able to push to the repository and review pull requests. This will preserve existing issues and will not require updating any metadata on MELPA or anywhere else.
If you would rather no longer be associated with the project, we could move it to a new organization. This will also preserve issues etc., and moving will create a redirect, so no metadata will need to be updated either.

sviridov commented 4 years ago

Hey,

Yes, I prefer option #2. Will you create such an organization? I will be able to move other undercover.el related projects to it as well.

CyberShadow commented 4 years ago

OK, done: https://github.com/undercover-el

sviridov commented 4 years ago

@CyberShadow, thank you! I have transferred all related repositories under this organization. I hope you have permission to maintain this project now.

CyberShadow commented 4 years ago

Looks good, thanks! I will apply my fixes soon.

One thing I should point out is that if you do decide to contribute in the future, you probably want to avoid forking the repositories there back to your account, as that will break the redirect (and then we will have to update external metadata etc.). Instead, you can create a branch on undercover-el/undercover.el or just push there directly as before.

sviridov commented 4 years ago

Yep, make sense, thank you!