underctrl-io / commandkit

Only focus on what matters - Let CommandKit handle your commands and events in your Discord.js projects!
https://commandkit.js.org
MIT License
86 stars 12 forks source link

Fix for ButtonKit & Signals Docs #23

Closed NotM1Dev closed 9 months ago

NotM1Dev commented 10 months ago

I've changed two files.

netlify[bot] commented 10 months ago

Deploy Preview for commandkit ready!

Name Link
Latest commit bd531428dbe97f2f149901c0ee0cab9246a5d6e6
Latest deploy log https://app.netlify.com/sites/commandkit/deploys/654d3c0ebf446d0008fd9907
Deploy Preview https://deploy-preview-23--commandkit.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

NotM1Dev commented 10 months ago

For using-signals.mdx: Instead of variable names such as disposeValue and disposeCount, I think names such as disposeValueSubscribers and disposeCountSubscribers would be more descriptive.

Okay, I'll rename them.

NotM1Dev commented 10 months ago

@notunderctrl I've renamed the variables to use the better names you've suggested. A review would be appreciated.