search

underfitted / bnomial-web3

Smart contracts for bnomial
MIT License
0 stars 0 forks source link

Enable slither external-function detector #29

Open haltakov opened 2 years ago

haltakov commented 2 years ago

Currently, the external-function detector in slither is disabled in the CI, because it has a false positive issue coming from the OpenZeppelin contract (tokenURI declared as public instead of external). We should find a better way to deal with this than excluding the whole detector.

https://github.com/underfitted/bnomial-web3/blob/7833cb76c7295f8ff524c16c761953a82a180aa3/.github/workflows/slither.yml#L56

haltakov commented 2 years ago

I tried slither-ignore-next-line and triage mode, but it somehow didn't work.