search

undergroundwires / privacy.sexy

Open-source tool to enforce privacy & security best-practices on Windows, macOS and Linux, because privacy is sexy
https://privacy.sexy
GNU Affero General Public License v3.0
3.85k stars 163 forks source link

[Bug]: `ERROR: Invalid syntax. Type "REG ADD /?" for usage.` #380

Open guihkx opened 3 weeks ago

guihkx commented 3 weeks ago

Description

When applying the Disable Microsoft feature trials tweak from version 0.13.5, I got the following error:

--- Disable Microsoft feature trials
The operation completed successfully.
The operation completed successfully.
ERROR: Invalid syntax.
Type "REG ADD /?" for usage.

How can the bug be recreated?

  1. Apply the Disable Microsoft feature trials tweak

Operating system

Windows 11 Pro 24H2 (build 26100.1000)

Script file

No response

Screenshots

No response

Additional information

No response

undergroundwires commented 3 weeks ago

Thanks for the bug report @guihkx.

It's really helpful with all details you provide such as OS/app version.

I see that it was introduced as part of 0.13.4 due to a typo included in commit cec0b4b. It's due to /f flag incorrectly being /.

I will fix this by getting rid of all these manual reg add commands by replacing them with a common function like SetRegistryValue in windows.yaml. This way, the change will not only fix this bug but will prevent the code against this kind of typos again.

guihkx commented 3 weeks ago

Superb! Thank you for looking into this so quickly. :)