understrap / understrap-child

The starter child theme for Understrap, the renowned open-source WordPress starter theme.
GNU General Public License v3.0
581 stars 331 forks source link

Could parent and child be updated together? #127

Closed ErinPo closed 6 years ago

ErinPo commented 6 years ago

Current parent version has bs4 final, but child is still on beta3.

ErinPo commented 6 years ago

Also, WP update version and Github version could be updated simultaneously.

Is there a particular reason why the child is not available through WP update?

Nukium commented 6 years ago

+1

Is there any good reason that the cild theme use its own bootstrap copies ? I think the parent theme should handle that.

ErinPo commented 6 years ago

I wonder if the author no longer cares for the child theme.

eberhapa commented 6 years ago

The child theme is just here to include all basic template files als structure. The child theme also deregisters all styles and scripts. You should manage the child theme yourself and get comfortable with npm. If the parent theme gets updated you have to update the child theme yourself. The parent theme for example includes all bootstrap files and fontawesome 4. What if you just need parts of bootstrap and fontawesome5? The child theme can't get updated like the parent theme because that would overwrite all your custom files. Further reading for updating packages NPM update

holger1411 commented 6 years ago

Yes, there is a good reason for using own dependencies for the child theme indipendently from the parent. It lets you rebuild your scripts and styles without the need to do it in the parent theme (which will make it un-updateable, which makes a child theme useless).

For example: You want to replace the default Bootstrap $primary color, you have to re-generate the css file from scss sources. If you change it in your child theme but you don´t have your own dependencies for generating the css file nothing will happen. If you change it in your parent theme you will loose this changes during an update.

So this way adds a clear border between parent and child theme. The child has its own independent dev and dependency stack. You can even replace Gulp with Grunt, npm with Bower etc. (that makes the child theme un-updateable, but not the parent)

ErinPo commented 6 years ago

Thanks @eberhapa and @holger1411, I appreciate the explanations. I will be looking to familiarize myself with one of those package managers when I get some time.

blachawk commented 6 years ago

@holger1411 while on topic, Does the UnderStrap team have any document resources online on how to update UnderStrap themes? Something I go to every time when I need to push for a major release update?

Thomas-A-Reinert commented 6 years ago

Nope, not yet. As already commented in https://github.com/understrap/understrap/issues/654

Thomas-A-Reinert commented 6 years ago

All issues should be resolved. Feel free to reopen if any problem persists.