search

understrap / understrap

Underscores + Bootstrap = Understrap, the renowned open-source WordPress starter theme.
https://understrap.com
GNU General Public License v3.0
3.05k stars 960 forks source link

Roadmap? #1089

Closed Thomas-A-Reinert closed 3 years ago

Thomas-A-Reinert commented 4 years ago

Issue is about..

It would be cool to have a Roadmap for an upcoming release on WordPress.org.

For that we should have..

gp0 commented 4 years ago

An absolute NO-GO is that new admin main-menu entry for "OverStrap". GOSH, DUDE! THat´s TOTALLY obstrusive and an absolute NOGO. I cannot disable it, I do NOT want to have that for my clients and not even on a stock install. Go find another way for introducing your premium shizzle. But GET RID OF IT AT ONCE.

+1 for that from an outside perspective, just did a fresh clone for a project and the first thing that is see is an admin menu with a nagscreen? Oof.

The commit adding it seems to be this one

In addition it pulls in some kind of analytics bullshit:

<iframe src="https://understrap.com/overstrap/?wp=1" id="inv_os_analytics"></iframe>

The code also looks well, not exactly trust-building, e.g. throws warnings (seriously?):

Notice: Undefined index: tab

here:

function understrap_overstrap_page() { add_thickbox(); $active_tab = $_GET[ 'tab' ]; if($active_tab == ''){$active_tab = 'featured';} ?>

$active_tab is then.. never used? What?

IanDelMar commented 4 years ago

@ semantic versioning: Yes! And let’s get rid of the annoying sidebar checks for UnderStrap 1.0.0!

@ marketing overstrap: My 2 cents - I think a “theme settings” page with helpful resources (eg links to this repository and the documentation, etc) and recommended stuff (eg the free child theme and the OverStrap thing would be sufficient marketing. People will most likely not get annoyed because there is also actual useful stuff provided. In case the feed is a must, we could offer a disable option there as well. @UnderstrapFramework check how Yoast was bashed for their aggressive black Friday marketing strategy. Ppl don’t like stuff like that. In fact you force each user/dev to use a child theme to just disable the feed and the menu.

@ analytics: WTF! I just removed GA from this repository. I was not aware that I got tracked from my very first day here. Is this shit even GDPR compliant?

noelspringer commented 4 years ago

check how Yoast was bashed for their aggressive black Friday marketing strategy. Ppl don’t like stuff like that.

+1

And yes, the inc/wp-admin.php file is where the Overstrap meta-box and menu item have been added.

pattonwebz commented 4 years ago

Opened some issues about the tracking, new page, dashboard widget etc.

UnderstrapFramework commented 4 years ago

The GA and the random useless code (not sure how I copied that) have been removed

a more helpful page with links to a help questions & answers section (which is next on my to do list) would be great for the 1.0 release

the RSS widget can be minimized as well, it does have some useful content come up but my recent efforts have been on marketing

what documentation are you talking about @Thomas-A-Reinert?

pattonwebz commented 4 years ago

@UnderstrapFramework feel free to close out my issues as you make adjustments. Didn't mean to open so many but figured best to tackle each one at a time :)

IanDelMar commented 4 years ago

@UnderstrapFramework maybe it would be the best to remove it completely (see #1099), rethink the whole thing and to come up with a better solution.

UnderstrapFramework commented 4 years ago

Removed and will rethink a better solution

pattonwebz commented 4 years ago

I'm happy to help setup the alternaitive solution. I think a theme info page + an admin notice could work for most of things. The tracking is a little complicated to manage because it requires opt-in consent from users before it can happen.

Also my suggestions come from perspective of the wordpress.org theme review team and the themes we have in the directory there. Some of the items may be suitable for themes that are not in the directory (but I'm assuming that at some point you will want to update the .org theme with what is made here in the repo as holger was doing).

UnderstrapFramework commented 4 years ago

Thanks @pattonwebz, yes I would like to update .org soon

A more helpful solution would be ideal, il put some thought into it

UnderstrapFramework commented 4 years ago

Hey @Thomas-A-Reinert, what would be the best way of managing this road map? A forum thread or maybe something a bit more dynamic with voting etc.?

I have an idea in my head for something on UnderStrap.com that requires signing up and voting based on:

https://codecanyon.net/item/dw-question-answer-pro-wordpress-plugin/15057949

but I don't want to put the effort into building that if its overkill

Thomas-A-Reinert commented 4 years ago

A poll needs questions/tasks being setup before and those probably need discussion and people who assign/feel responsible for those tasks. I don´t see a problem discussing this in the internal "teams" area. No need to do that in an area that´s open to everyone. It´s not that I want to hide it from the normal users, but I think some things should be discussed internally before.

About that poll thingie - I personally will not sign up for anything I don´t need regularly. And I guess the same goes for most of the other devs hier.

Thomas-A-Reinert commented 4 years ago

@UnderstrapFramework You still didn´t reply to my request. But it seems that you did major changes to the original Website. Not up to me to judge that. But removing any link to the git-Repo, well.... No Comment

You/We need a roadmap. For EVERYTHING. We - the community - NEED to know about ANY change to make to the eco-system. It MAY be that we gonna support you - It may be not.

No matter what - GET US INFORMED BEFORE YOU UNDERTAKE ANY STRANGE THINGS!

ghost commented 4 years ago

I was also surprised to see the Github badge removed from the homepage.

@UnderstrapFramework and @Thomas-A-Reinert why not create a new project for contributors to add tasks/features/issues to an unsorted backlog of potential jobs-to-be-done?

0dp commented 4 years ago

Great idea!

Thomas-A-Reinert commented 4 years ago

@shrthnd - would you care to explain? I really don´t get the point but that´s probably just me.

ghost commented 4 years ago

Sure thing, @Thomas-A-Reinert.

Github "Projects" are essentially kanban boards. Instead of a poll, @UnderstrapFramework might create a single project called "Roadmap v2" setup something like this: https://github.com/helpful-dev/understrap/projects/1

Contributors already log in through github.com so there won't be additional account registration required to participate. It's also possible to import existing issues which feels like it has the potential to be useful.

¯\(ツ)/¯

0dp commented 4 years ago

Yeah so ideas and suggestions for improvements can be gathered in one place. But not sure if it's a great place for discussing.

ghost commented 4 years ago

Yeah so ideas and suggestions for improvements can be gathered in one place. But not sure if it's a great place for discussing.

I see your point. At best, issue threads (like this one) imported into these boards would only be as useful as Github issues already are for group discussions.

For real-time chat Discord has an awesome interface/experience and other open source projects (like GatsbyJS) use this as an alternative to Slack.

Thomas-A-Reinert commented 4 years ago

Thanks for the update, @shrthnd . The discord chan should be avail at https://discord.gg/JTC7Jt now and the original Slack Chan @ https://understrapworkspace.slack.com/archives/CBJJAUKR8

Edit: Sorry, former Discord link didn´t seem to work. Please try and confirm that this one does.

Thomas-A-Reinert commented 4 years ago

Hey @UnderstrapFramework : 12 days passed. No answer yet. You promise stuff and can´t keep it. AGAIN. You told me to mention you - but anyways.. you don´t answer anything.

UnderstrapFramework commented 4 years ago

Hey Thomas, the commercial elements were removed 12 days

Im keeping an eye on the threads you mention me in

Thanks

Thomas-A-Reinert commented 4 years ago

Darn, this seems to become pointless. Read the topic. It says "ROADMAP". None avail yet.

No one left any word about the commercial elements within the past X days. But there are still a lot of questions left unanswered if you´d read the whole thing here.

And sorry: I forgot to answer your question about the UnderStrap documentation. https://lmgtfy.com/?q=understrap+documentation - not too hard to find if one would care about it.

Thomas-A-Reinert commented 4 years ago

Btw - you f***cked up the search function on your site, see https://understrap.com/?s=YourMother . Just wanted to let you know

UnderstrapFramework commented 4 years ago

Hey Thomas, thanks for the response

The search functionality is not needed right now as there's no on-site search bar but il fix that in the future sometime soon

You mentioned in the first post "Sounds ridiculous: But the updated docs NEVER got published ANYWHERE" - so I assumed it wasn't public (Google can't index non-public content) - so was wondering where they were so I could publish them

0dp commented 4 years ago

Understrap has its own documentation, which you should have been briefed in. It's outdated as mentioned. https://understrap.github.io

We've been working on an updated documentation, but it's far from done, so that should get some TLC to come up to date.

UnderstrapFramework commented 4 years ago

Thanks @0dp for the link, im trying to find where to edit that right now but not having much luck

pattonwebz commented 4 years ago

@UnderstrapFramework that documentation is handled via github pages from a different repo - this one: https://github.com/understrap/understrap.github.io.

Not sure if you have access to it, I don't have any access there.

UnderstrapFramework commented 4 years ago

Hey @pattonwebz thanks for the link, im in now!

Seems Holger hasn't changed it since March 2019, il keep an eye out for updates to this documentation from now on

noelspringer commented 4 years ago

@UnderstrapFramework What is the roadmap / timeframe for the next point release for WordPress.org?

UnderstrapFramework commented 4 years ago

It should probably be soon as it hasn't been updated in a while, maybe early Feb?

I personally have no requests for any features to be added to US, just fixes that are important obviously

If anyone wants to speak out about anything they want to see included in the next update that would be helpful

0dp commented 4 years ago

The build system needs to be updated. (WIP)

The docs needs to be updated as mentioned. The build system will most likely require to have it's documentation updated for instance.

Understrap-child needs defibrillation afterwards.

Maybe early February is optimistic for 'breaking changes'

On Thu, 2 Jan 2020, 12.47 UnderstrapFramework, notifications@github.com wrote:

It should probably be soon as it hasn't been updated in a while, maybe early Feb?

I personally have no requests for any features to be added to US, just fixes that are important obviously

If anyone wants to speak out about anything they want to see included in the next update that would be helpful

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/understrap/understrap/issues/1089?email_source=notifications&email_token=AA3ZH773KABHMXTFCXKYYS3Q3XH65A5CNFSM4J3UEQ3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH6FRNA#issuecomment-570185908, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3ZH75HQPX2WGSYR2F2CCLQ3XH65ANCNFSM4J3UEQ3A .

UnderstrapFramework commented 4 years ago

thanks @0dp

noelspringer commented 4 years ago

OK perhaps my terminology is not correct since I was referring to a minor update that would incorporate recent merges (if they are not breaking changes), in particular Woocommerce template updates.

The UnderStrap.com website states that UnderStrap is Woocommerce ready whereas in fact it is not.

UnderStrap 0.9.4 has Woocommerce templates that are out of date since August last year with the release of Woocommerce 3.7.0. Some subsequent Woocommerce plugin updates have incorporated additional template changes. When the UnderStrap version of a Woocommerce template is not in sync with the Woocommerce plugin template version and a user runs the WP dashboard Woocommerce Status report, the out-of-date UnderStrap templates show up in red with an alert message that the template(s) are out of date.

So this is the case for everyone running Woocommerce and using the current WordPress.org version of UnderStrap. The way to fix it is to issue an updated release which incorporates the latest Woocommerce merges. Only then will UnderStrap be "Woocommerce Ready".

0dp commented 4 years ago

Then maybe it's time to Branch out now. Focussing on polishing the current master for release, and then have a new branch for features?

noelspringer commented 4 years ago

@0dp +1 for branching. Your suggestion sounds similar to the Gitflow approach which you may be familiar with.

Essentially, the master branch is the production branch.

A "develop" branch is created from the master branch and is also a permanent branch. Feature/topic branches are forked from the develop branch and pull requests are made back to the develop branch.

When a new point release is required, the develop branch is merged into master and becomes the new production version.

As you pointed out, this would allow the master branch to be "polished" via the develop branch and a new point release incorporating recent, necessary updates could be made available on WordPress.org. In the meantime other features could be worked on and pull requests made to the develop branch.

Do you think this type of workflow would be beneficial?

cc - @UnderStrapFramework

0dp commented 4 years ago

Exactly @noelspringer

noelspringer commented 4 years ago

@0dp I guess the main contributors would need to agree to this workflow then.

Also, would @UnderstrapFramework, as the repo admin, need to create the permanent "develop" branch if others agree to move forward with this workflow?

In what ways do you and others consider that the current state of the master branch needs to be polished in order to move forward with a new point release?

cc- @UnderstrapFramework

0dp commented 4 years ago

@noelspringer yeah, but I have a feeling that this one will get support from everyone.

I believe so, as it needs to be someone with the appropriate permissions to create it or merge it in from a PR.

This is in no way a complete list:

@IanDelMar have made a handful of other valuable PR's lately as well.

With those tested, merged and retested I suppose we have a baseline for a new release.

...what am I missing? 🤔

noelspringer commented 4 years ago

@0dp, @UnderstrapFramework I can confirm that all the Woocommerce templates currently used by UnderStrap are up-to-date with the Woocommerce plugin's templates. Verified with the Woocommerce Status report.

Are there other features that need to be added?

Thomas-A-Reinert commented 4 years ago

No annotation so far from the "repo admin" aka @UnderstrapFramework about this topic for about two month now. Just saying that the "management" of this repo sucks a fucking lot.