Patch 1

[hachesilva]

Changes in source strings:

• from ' from ' to esc_html_e( ' from '. 'undestrap' )

Description

• Replace a hardcoded string in the search results page with a translatable string

Motivation and Context

• A hardcoded strings appears in the readmore button in the search results page

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Refactoring (a code change that neither fixes a bug nor adds a feature)
• [ ] Styling (changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc))
• [ ] Development (changes that affect the build system or external dependencies)
• [ ] Documentation (changes that affect existing inline documentation)

Checklist:

• [x] I pulled my branch from develop.
• [x] I am submitting my pull request to develop.
• [x] I have resolved any conflicts merging this pull request would create.
• [x] I have checked that there aren't other open Pull Requests for the same update/change.
• [x] My code follows the code style of this project.
• [x] I have performed a self-review of my own code.
• [x] I have commented my code, particularly in hard-to-understand areas.
• [ ] (Optional) My change requires a change to the documentation.
• [ ] (Optional) I have updated the documentation accordingly.
• [x] (Optional) My change requires a change to the translations.
• [ ] (Optional) I have updated the translations accordingly.
• [ ] composer phpcs has passed locally.
• [ ] composer php-lint has passed locally.
• [ ] composer phpmd has passed locally.
• [ ] composer phpstan has passed locally.
• [ ] I have read the CONTRIBUTING document.

[IanDelMar]

Hi @hachesilva! While the "from" should definitely be translatable, I'm wondering if we should try to fix the whole string, which is actually "Read More... from [post title]".

[bacoords]

Hi @hachesilva - let us. know if you plan on updated the patch re https://github.com/understrap/understrap/pull/2168#issuecomment-1866899547 or if you'd like us to close the PR