undertow-io / jastow

Jasper fork for Undertow
Apache License 2.0
22 stars 46 forks source link

Calling the JspServlet by a background thread #24

Open ghost opened 8 years ago

ghost commented 8 years ago

I also posted this on StackOverflow: http://stackoverflow.com/questions/33878758/jastow-jsp-integration

The README, says that the integration requires a "periodic call to the PeriodicEvent interface on the JasperServlet instance". I assume that this is for compiling new JSPs and unloading non-existent JSPs. This would be required only if JSPs are being modified or added/removed while the server is running, right? However, I noticed that when using Jastow with Undertow, the JSPs are being recompiled every time they are changed. This is happening without my server application calling the PeriodicEvent interface. Is the call by the background thread to the JspServlet still necessary? If so, for what?

ctomc commented 7 years ago

No it is not necessary anymore as we also support filesystem notifications for changing JSPs when they are modified. However background thread refreshing is still supported as some filesystems don't support notifications on file changes.