search

undertow-io / jastow

Jasper fork for Undertow
Apache License 2.0
22 stars 46 forks source link

[UNDERTOW-2214] Jastow compilation error when mixing EL and scriptlet expressions after UNDERTOW-1319 #78

Closed rmartinc closed 1 year ago

rmartinc commented 1 year ago

Issue: https://issues.redhat.com/browse/UNDERTOW-2214

Reverting UNDERTOW-1319 to be compliant with the spec. In a JSP tag attribute a value scriptlet expression must appear by itself (full attribute), multiple expressions, and mixing of expressions and string constants are not permitted. Adding a simple test in the TagLibJspTestCase to ensure the behavior is not changed again.

If anybody prefers an intermediate solution (for example accepting the previous bad behavior by default or after setting a system property) just let me now. But I prefer to be spec compliant and do not complicate the validation (as the previous fix was incomplete).

PR for 2.0.x. PR for 2.2.x: https://github.com/undertow-io/jastow/pull/77

TomasHofman commented 1 year ago

Hello @rmartinc, just checking - there's no need for a master branch PR?

rmartinc commented 1 year ago

@TomasHofman Master is 2.2.x now (at least 2.2.x is the default branch in the project). So https://github.com/undertow-io/jastow/pull/77 is the master/2.2.x PR. :smile:

ropalka commented 1 year ago

Thanks @rmartinc !