search

underworldcode / underworld3

https://underworldcode.github.io/underworld3/
Other
21 stars 10 forks source link

adding mpicc system path of setup.py #243

Closed gthyagi closed 1 month ago

gthyagi commented 2 months ago

Hi,

I've updated the setup.py file to retrieve mpicc from the system-wide installation instead of relying only on the environment installation.

gthyagi commented 2 months ago

242, issue reported here.

gthyagi commented 1 month ago

The reason for issue #242 is that mpi4py version 4 does not provide the necessary path information when calling get_config(). For more details and potential solutions, please refer to the discussion in this GitHub issue: https://github.com/mpi4py/mpi4py/issues/532

julesghub commented 1 month ago

@gthyagi, looking at this more it doesn't seem like we need to even use environ["CC"] anywhere. Can you confirm?

If the code is obsolete let's remove it.

gthyagi commented 1 month ago

@julesghub yes, we can remove these lines from the setup.py file. https://github.com/underworldcode/underworld3/blob/372ecce37d1867266471c4d60b6dcf47770f12e9/setup.py#L13-L34

julesghub commented 1 month ago

ok, then I'll close this PR and I will make a new one to remove