Document unix:// paths and add test for these

plaes commented 9 years ago

Add note about unix:/// configuration support to README.

PS. rediss:// is also parsed properly but I currently don't have setup for that.

landscape-bot commented 9 years ago

Code quality remained the same when pulling d23c958 on plaes:master into 8ced34c on underyx:master.

plaes commented 9 years ago

Is the test server running custom redis-py which disallows non-'redis:.//' urls?

landscape-bot commented 9 years ago

Code quality remained the same when pulling d23c958 on plaes:master into 8ced34c on underyx:master.

underyx commented 8 years ago

Actually I think the issue here was that unix:// URL support was only added in redis-py 2.7.x, and the CI suite checks 2.6.x as well. The other builds failed because of a PEP8 violation. I'm now committing this change manually to https://github.com/underyx/flask-redis/tree/release/0.3.0 and it should make it into master real soon. Sorry about the long, long wait! Two things to note:

The test seems largely unnecessary here; I think as it's just testing whether redis-py's URL parsing works correctly it does not need to be included with this project. The test result is completely independent of Flask-Redis. Therefore, I'm not including that in the commit.
Your second commit (https://github.com/underyx/flask-redis/pull/21/commits/d23c958f31de051e993566f8dd032bebb4897ac8) does not seem to be fixing an issue to me. The original form should be correct (and perhaps a tiny bit nicer) as well.

Since I basically just copied your change, I'm setting you as the author of the commit. You can see it attributed to you here: https://github.com/underyx/flask-redis/commit/d27af448e8c408b50d641680746bbbc4ba0cd53f

Thanks a lot for the contribution! 👍

underyx / flask-redis

Document unix:// paths and add test for these #21