search

underyx / flask-redis

A Flask extension for using Redis
Other
436 stars 71 forks source link

Being able to pass config kwargs into redis-py #24

Closed giyyapan closed 8 years ago

giyyapan commented 8 years ago

I'm using flask-redis in my project, and I need to pass some config params into redis-py ( "decode_responses = True" in my case), so I did this change.

I'm not sure if this commit will bring anything bad, I'm just trying the most simple solution that works for me.

This is the first time I create a pull request, let me know if I'm doing this wrong :p

underyx commented 8 years ago

Hi @giyyapan!

Thank you for your contribution! I am really, really sorry that I ignored this PR for so long. It pains me to see that this was your first experience with getting involved with the open source community. I don't have any good excuses; it just that there was a lot going on in my life, little time for this project, and I kept procrastinating and putting off reviewing this pull request until an embarrassingly long time has passed.

I've made some changes to the underlying code this morning, so I had to update your commits to work with this new version. Rest assured, the commit is still attributed to you — you can see it here: https://github.com/underyx/flask-redis/commit/fdacb06d191371ef9fcd76e7425d47dede9a70b4

Thanks a lot again, I hope your next experience with open source contributions will be a lot more pleasant!

giyyapan commented 7 years ago

@underyx Oh, please don't be sorry anymore because same thing just happened to me! (as you can see now :p ) Glad to see this feature was added officially, this IS a pleasant contribution experience to me!