Reorder command sequence documented in contributing instructions

undp / SeleniumProbes

Library of building blocks to construct probes generating metrics for automated testing of web app performance and availability

MIT License

1 stars 2 forks source link

Reorder command sequence documented in contributing instructions #1

Open cyberladysj opened 5 years ago

cyberladysj commented 5 years ago

Reversing install procedure: Poetry should be installed first and then pre-commint would follow. "git clone https://github.com/undp/seleniumprobes.git SeleniumProbes cd SeleniumProbes pre-commit install poetry install"
Include "pyenve" installation in ~/.bashrc, verifying virtual environment persistent installation.

OK-UNDP commented 5 years ago

@cyberladysj, thanks for spotting the doc error!

Also, the third step of the Managing Virtual Environments section of CONTRIBUTING.md mentions that .bashrc should be edited for pyenv to engage automatically. So, does this address your second bullet point or you meant something else?

cyberladysj commented 5 years ago

Yes, editing .bashrc for pyenve to engage automatically addresses my second bullet point. Thank you