undp / design-system

UNDP Design System
https://design.undp.org
MIT License
23 stars 13 forks source link

[SB8]: some components controls inadvertently exposing internal properties #1358

Open Jura opened 5 days ago

Jura commented 5 days ago

Multiple components affected, example: https://develop.design-system.pages.dev/?path=/story/foundation-logos--pnud-logo-blue image

theadamparker commented 5 days ago

Link component is exposing a "variant" control which isn't needed.

https://develop.design-system.pages.dev/?path=/story/foundation-typography-links--link-story

Screenshot 2024-09-12 at 5 26 43 PM

theadamparker commented 5 days ago

"Checkbox" component is exposing label_pos

https://develop.design-system.pages.dev/?path=/story/components-forms-checkbox--checkbox-story

Screenshot 2024-09-12 at 5 28 38 PM

theadamparker commented 5 days ago

Accordion is exposing headerText and descriptionText

Screenshot 2024-09-13 at 11 07 11 AM

theadamparker commented 5 days ago

Author card is exposing type and button_option.

Screenshot 2024-09-13 at 11 09 53 AM

theadamparker commented 4 days ago

Parallax cards is exposing locale.

Screenshot 2024-09-13 at 11 31 33 AM

CalebLuster commented 1 day ago

fixed