uneasyguy / binance_data

Python package to retrieve historical data from Binance
MIT License
46 stars 9 forks source link

1min kdata incomlete #6

Open Dilidonka opened 3 years ago

Dilidonka commented 3 years ago

Seems like due to the limitation of klines data you can get from Binance API for 1000 results, you loose last 440 minutes of every day. For 1 minute periods, need to download data in 2 iterations and merge them

uneasyguy commented 3 years ago

This should happen already, are you experiencing otherwise?

Dilidonka commented 3 years ago

Frankly saying, did a fix myself ;) But thank you so much to react fast!

MikeMaxNow commented 3 years ago

There is still an error when I later run kline_data again (with already existing CSV files). When appending the new data, one day will contain double (identical) data rows.

I fixed it myself by sorting the full final CSV file and deleting all double rows. Better this than missing data...