search

unee-t / frontend

Meteor front end
https://case.dev.unee-t.com/
GNU Affero General Public License v3.0
9 stars 17 forks source link

Reordered depedencies for tests #883

Closed nbiton closed 4 years ago

nbiton commented 4 years ago

@kaihendry I moved some code around to create a uni-directional dependency between two major modules, as for some reason, Puppeteer can't resolve code with bi-directional dependency as well as the Meteor runtime. Tests are running fine after these changes,

kaihendry commented 4 years ago

·[0m·[91mnpm ·[0m·[91mERR!·[0m·[91m Could not install from "node_modules/meteor-node-stubs/readable-stream@git+https:/github.com/meteor/readable-stream.git#2e9112d7d31a2af6e0682db0e18679b1e5fd4694" as it does not contain a package.json file.

I also see that ·[0mThe command '/bin/sh -c meteor npm install --save postcss-easy-import' returned a non-zero code: 1 is not failing in the Docker build in the AWS CodeBuild job.

Can you check the Docker build works along with the changes to make npm t work?