search

unee-t / frontend

Meteor front end
https://case.dev.unee-t.com/
GNU Affero General Public License v3.0
9 stars 17 forks source link

WIP - Merge unee t ins improvements - Phase 1 #892

Open franck-boullier opened 4 years ago

franck-boullier commented 4 years ago

Overview:

This is to make sure we can 1- Deploy the frontend (fix deployment bug identified on 06/02/2020) 2- Get some of the improvements we made in the Unee-T INS fork 3- Start working on using AWS Parameter Store variables instead of hardcoded values to make this more versatile.

Issue we MUST fix:

bcrypt fails at the install script at node-gyp rebuild

Warning:

This branch will NOT deploy with TRAVIS CI UNLESS all the settings that Travis CI needs are configured and correctly set in the Travis Setting for each environment!

franck-boullier commented 4 years ago

More info:

The deployment error is probably linked to a change we have to make in the package.json file

on line 22, we have replaced "bcrypt": "^1.0.3", with "bcrypt": "^3.0.6"

Mongo DB version:

In Unee-T INS we are using a more recent version of the Mongo DB. We need to evaluate if this has an impact (it probably has: connection string is different)

kaihendry commented 4 years ago

The Docker build fails https://media.dev.unee-t.com/2020-02-07/merge_unee-t_ins_improvements.txt which appears to be some fibers dependency. I think there is a crazy balancing act between:

  1. Node version
  2. Bcrypt version https://github.com/kelektiv/node.bcrypt.js#version-compatibility
  3. Fibers version
  4. Meteor version

Sidenote: Bit concerning that frontend master is also breaking: https://media.dev.unee-t.com/2020-02-07/frontend-master.txt ... I'm not sure how this happened.

I can see a bcrypt error here https://github.com/unee-t/frontend/commit/c9722427f4d35bf51bb9b1786a034b07533ad7e3 from Dec 3rd. This should have been addressed earlier.

kaihendry commented 4 years ago

I saw your latest commits to https://github.com/unee-t/frontend/blob/merge_unee-t_ins_improvements/.travis.yml to put back Docker commands instead of https://github.com/unee-t/frontend/blob/master/buildspec.yml

I wish this was a separate PR titled "Deprecate CodeBuild in favour of all building happening in Travis"

Then this might be sane to follow.

Anyway, big issue with CodeBuild is that it doesn't integrate with Github well at all. So it is a good idea to move back to Travis imo btw.

franck-boullier commented 4 years ago

Trying to look into why Docker build is nor working with Node Js 12. There was a similar looking issue here: https://github.com/laverdet/node-fibers/issues/409. Need to check if the fix implemented will also work for us. See https://github.com/unee-t/frontend/pull/892/commits/6bbc688d70e60ebd67aa5eab0a1751a260489a49