search

unexpectedjs / unexpected

Unexpected - the extensible BDD assertion toolkit
http://unexpected.js.org/
MIT License
371 stars 29 forks source link

Don't require `array-like` subtypes to have the same constructor in order to be equal #855

Closed papandreou closed 1 year ago

papandreou commented 1 year ago

Updating jsdom in unexpected-dom is causing trouble because NodeList instances from different windows have different constructors in jsdom 16 and above.

Seems like the easiest way to get unexpected and unexpected-dom to DTRT in that kind of scenario is to relax this requirement a bit and only require the objects to have the same array-like subtype.

papandreou commented 1 year ago

Released in 13.2.0