search

unexpectedpanda / retool

Retool: a better filter tool for Redump and No-Intro DAT files.
BSD 3-Clause "New" or "Revised" License
355 stars 23 forks source link

Fix python 3.8 compatibility #192

Closed 0xC0D3D34D closed 2 years ago

0xC0D3D34D commented 2 years ago

Generic types for list, dict etc was not introduced until python 3.9. To keep back compatibility with python 3.8 import List (or other needed type) from typing and alias with capitalized type i.e. List[Any]

unexpectedpanda commented 2 years ago

You're absolutely right, Retool v1 is meant to be targeting Python 3.8. Python 3.9 is required for v2, and I'd been working in it there.

Thanks for the PR!