Bug with latest No-Intro datfiles

unexpectedpanda / retool

Retool: a better filter tool for Redump and No-Intro DAT files.

BSD 3-Clause "New" or "Revised" License

343 stars 21 forks source link

Bug with latest No-Intro datfiles #195

Closed Jaylinx closed 2 years ago

Jaylinx commented 2 years ago

Latest datfiles from No-Intro crashes on Retool, NES, Genesis, N64 and several others. I don't know if they changed something in their process.

It crashes on individual selection and I have this error message on folder selection

Error: XML file doesn't conform to Logiqx dtd. :4094:0:ERROR:VALID:DTD_UNKNOWN_ATTRIBUTE: No declaration for attribute sha256 of element rom. Skipping file...

unexpectedpanda commented 2 years ago

Just No-Intro ignoring their DTD again by introducing SHA256 hashes. I'll patch things when the opportunity arises, but it means I also need to add the new hashes to the output DAT.

unexpectedpanda commented 2 years ago

This should be fixed in 1.08.

Jaylinx commented 2 years ago

Great, thanks !

Jaylinx commented 2 years ago

New bug with latest NES and N64 datfiles

Error: XML file doesn't conform to Logiqx dtd. :13223:0:ERROR:VALID:DTD_UNKNOWN_ATTRIBUTE: No declaration for attribute header of element rom. Skipping file...

unexpectedpanda commented 2 years ago

Not a bug, that's No-Intro violating its own standards yet again and so failing the DTD check.

The introduction of headered DATs has been a little chaotic, much like the nodump experience a little while back. I wouldn't be surprised if this took a little while to stabilize. Kind of surprised they put it as an attribute on the rom element, and didn't introduce a header element, which would have been a more scalable option.

Come Retool 2.0 there'll be an option to skip the DTD check. DTDs are meant to keep things predictable, but if No-Intro keeps breaking things 🤷

unexpectedpanda commented 2 years ago

Fixed in 1.09.