unexpectedpanda / retool

Retool: a better filter tool for Redump and No-Intro DAT files.
BSD 3-Clause "New" or "Revised" License
355 stars 23 forks source link

Nes errors on a fresh Dat from Retool using Clmamepro. #199

Closed slider6996 closed 2 years ago

slider6996 commented 2 years ago

Describe the bug When creating NES dat from latest updated Dat file from Dat O Matic for NES ( HEADERED ) and using Clmamepro it shows alot of crc32 errors and when running full fix on both left and right side for scan it just dumps all the roms into the backup folder without fixing the errors, i even tried Romulus and it does same thing, just moves the roms into a backup folder without fixing the issues.

To reproduce Download latest NES dat file for No Intro from Dat O Matic. Create custom dat file using Retool ( default options for English ), put dat file into Clmamepro, select New scan with Check and Fix applied and will see the errors.

Expected behavior To sort and select Roms how its suppose too

Operating system

Retool edition

Retool version For the command line edition of Retool, the version is shown when you run it with no other arguments.

For the GUI edition, click Help, then About.

Are you using custom global or system filters? If so, list them below

Global excludes: Demos etc etc Global includes:

System excludes:

System includes:

What other settings are you using?

Additional context Add any other context about the problem here. didnt have this issue before i thought when i used program prior, at least on other systems, maybe im just missing something? When i get back home tomorrow ill do some more tests testing snes and see if it does same thing.

On a fresh SNES dat download and test there is no errors using Retool then using the created dat with Clmame like the nes, maybe its just a nes thing?

For the error here i just selected Names and Size to show the errors below for the pictures

error 1

error 2 .

unexpectedpanda commented 2 years ago

This is likely related to the new headered/non-headered NES DATs. Retool inserts the CLRMAMEPro/RomCenter header skipper lines in the DATs regardless of whether it's needed or not. I'll need to do a little testing to see if this is an issue.

To confirm, the files you're scanning are definitely the headered versions and match the hashes in the original DAT? Or did you previously have unheadered files and you've scanned with the headered DAT?

slider6996 commented 2 years ago

they are 100% headered as i thought i had headerless by mistake but i double checked to make sure and def headered.

unexpectedpanda commented 2 years ago

Okay, confirmed this is to do with the header skipper lines. Retool 1.12 should be up shortly, and it copies across CLRMAMEPro and Romcenter directives from the source DAT, which fixes this problem.

unexpectedpanda commented 2 years ago

Thanks for the heads up, this should be resolved in 1.12. Give a holler if not.

slider6996 commented 2 years ago

Ok so update, it was bugging me why i was having this issue when i was like 99% sure i didnt have this issue before so i copied all the roms from download back into a folder and started over trying different things and the Parent Clone from Dat o Matic worked fine with the 1g1r mode with no errors but it deleted games it shouldnt hence me likeing the retool but when i made a dat with the retool i would get the error.

So i redid the dat from retool and when imported it into clmamepro i just instantly accepted the pop up about the header question without thinking about it and i think that was my boo boo, will post pic below of the pop up to confirm if im right, well it dont pop up no more unless u import a fresh dat of the nes so ill post pic of selecting the option manually. Honestly my only knowledge of headerless and headered is that the headerless is a no no for emulation so i always avoid it and thats the end of my knowledge and so when that pop up asking to skip the header skipper i just always hit yes.

When i hit no and rerun the scan it actually seems to scan properly and filter out properly so would that of caused the issue i described?

pop up

unexpectedpanda commented 2 years ago

The header skipper was previously incorrectly inserted by Retool in the headered DAT. Retool 1.12 fixes this (so definitely update). I suspect this is what caused your problem.

By not loading the header skipper on the DAT you created earlier, you've achieved the same effect.

slider6996 commented 2 years ago

Alright ill retest once im back home and edit this post after updating.

EDIT: Updated and redid fresh dat with Retool and no pop up occured this time with Clmamepro and scan still worked properly.