unexpectedpanda / retool

Retool: a better filter tool for Redump and No-Intro DAT files.
BSD 3-Clause "New" or "Revised" License
355 stars 23 forks source link

Update Sony - PlayStation 2.json #201

Closed rufotheone-fr closed 2 years ago

rufotheone-fr commented 2 years ago

OK, we have something to do about various KoF titles :

"NeoGeo Online Collection Vol. 3 - The King of Fighters - Orochi" (KoF 95/96/97) which is fine for jap audience but is superseded by "King of Fighters Collection, The - The Orochi Saga" (KoF 94/95/96/97/98)

"NeoGeo Online Collection Vol. 7 - The King of Fighters - Nests" (KoF 99 Evolution/2000/2001) which is fine to have for everyone because it's the only way to get KoF 99 Evo BUT it doubles KoF 2K/2K1 for jap audience

rufotheone-fr commented 2 years ago

And I cant' get "Persona 3 FES" to properly replace "Persona 3" and have the correct region selected (I want PAL region first). So I have reverted the list to get proper P3 + P3 FES while I'm trying to get it working the right way u_u

unexpectedpanda commented 2 years ago

Finally jumping on this, way too late!

And I cant' get "Persona 3 FES" to properly replace "Persona 3" and have the correct region selected (I want PAL region first). So I have reverted the list to get proper P3 + P3 FES while I'm trying to get it working the right way u_u

So you've got Europe above USA in your region list, but the USA version is turning up first? Yep, that's what I'd expect from how zero priority titles work. The order in the clone list matters for zero priority, as does the supported languages of the title. In this case it's hitting the USA version first, seeing it supports one of your highly preferred languages (likely implied from the region order), and thinks that's good enough. If you put the European version above the USA version in the clone list, it'll choose that instead. Mind you, if you do that, that'll mess things up for those who've put USA higher than Europe, not to mention those looking for 60Hz over 50Hz games.

Can you expand on why you prefer the PAL version? I'm assuming it's not so much the video standard, or that you're playing it on original hardware, but the potential for having additional languages like French (as European titles often don't have all languages listed)?

In the meantime, probably best not to mess with the clone list directly for this, I'll have to do some experiments to see how I would change Retool to fix the issue. At the moment Retool v2 works in a similar way (but with much more weight put on language support), so I might have to make changes there too. Basically zero priority titles can never be considered of equal priority (first in the list is always considered higher than second, second higher than third, and so on), which now seems to be flawed thinking on my part.

OK, we have something to do about various KoF titles :

"NeoGeo Online Collection Vol. 3 - The King of Fighters - Orochi" (KoF 95/96/97) which is fine for jap audience but is superseded by "King of Fighters Collection, The - The Orochi Saga" (KoF 94/95/96/97/98)

"NeoGeo Online Collection Vol. 7 - The King of Fighters - Nests" (KoF 99 Evolution/2000/2001) which is fine to have for everyone because it's the only way to get KoF 99 Evo BUT it doubles KoF 2K/2K1 for jap audience

😭 Always compilations breaking things. I don't think you're going to get anything perfect here. Let's see...

This looks like new functionality is needed to me, a conditional remove. Or at least the ability to remove from within a conditional override. I'm tempted to implement that in Retool v2 though, and leave v1 where it is in terms of functionality.

unexpectedpanda commented 2 years ago

I'm going to merge this in now, but I'll have a chat with you on Discord just so you don't miss the replies :)

Edit: Oops, I see you're not on Discord any more. Hopefully you see the replies above on Persona 3 FES and KoF!