search

unexpectedpanda / retool

Retool: a better filter tool for Redump and No-Intro DAT files.
BSD 3-Clause "New" or "Revised" License
355 stars 23 forks source link

Language overrides for systems not working #244

Closed Keiyuu closed 1 year ago

Keiyuu commented 1 year ago

When I check the "Override global settings" box on the languages tab in system settings, it's not taken into account when processing the DAT.

I noticed that it doesn't seem to save this particular checkbox at all because when you click on the DAT in the list after changing language settings, the override box gets unchecked again. This only happens on the languages tab.

unexpectedpanda commented 1 year ago

Thanks for the heads up -- fixed in beta 7.

Keiyuu commented 1 year ago

I just noticed this bug was only partially fixed. When trying to use an empty language list in an override it still won't save. It only works if you select at least one language.

unexpectedpanda commented 1 year ago

IIRC this was actually by design. It saves the override state, but if you have it enabled and no languages specified it falls back to the global order. It then turns off the override as no languages were specified.

Given the implied language order taken from regions this isn't a great thing, so I'll modify this in beta 8.

unexpectedpanda commented 1 year ago

Before I change the behavior -- what were you expecting to happen with an empty list?

In my mind this should be a two-level fallback. First get the implied language order from the system region order (if enabled). If that fails, then fall back to the global language order, whether implied or specified.

Edit: Ah the label on the box tells you that all languages are included if a box is empty, and fairly that's probably what you were expecting. I'll fix at least that...

Keiyuu commented 1 year ago

Edit: Ah the label on the box tells you that all languages are included if a box is empty, and fairly that's probably what you were expecting. I'll fix at least that...

Yeah, that's exactly what I was trying to achieve! I have a more refined global setting which I have as default but I change some things up for specific DATs and in this case I wanted it to consider all languages.

unexpectedpanda commented 1 year ago

Fixed in v2 beta 8.