search

unexpectedpanda / retool

Retool: a better filter tool for Redump and No-Intro DAT files.
BSD 3-Clause "New" or "Revised" License
355 stars 23 forks source link

Bug: Language prioritization is ignored #251

Closed prklx2 closed 1 year ago

prklx2 commented 1 year ago

With the latest 2.00.0 version of Retool it seems that the languages are ignored (completely?). The easiest way to confirm this bug is with bigger sets that have a lot of regional variants like PS1 and PS2.

For example, using PS1 redump dat: I have Finland as the top region and Finnish as the top language and still the exported list has Disney-Pixar Monsters, Inc. - Scare Island (Europe) instead of the Finnish variant: Disney-Pixar Monsterit Oy - Saeikkysaari (Finland)

Also seems to happen with Scandinavian releases and other non-English European releases.

Harry Potter and the Philosopher's Stone (Europe) (En,Fr,De) instead of Scandinavian variant Harry Potter and the Philosopher's Stone (Scandinavia) (Sv,No,Fi)

Need for Speed - Road Challenge (Europe) (En,Es,It) instead of the Swedish release Need for Speed - Road Challenge (Europe) (En,Sv) Swedish language is higher on my list than Spanish and Italian. I had all the languages included in this test.

This worked fine in previous releases and the higher region/language was always prefered when selecting the titles.

unexpectedpanda commented 1 year ago

With the language order:

And the region order:

I get:

Are you using global or system languages here? Could you provide your user-config.yaml and, if applicable, config/systems/Sony - Playstation (Redump).yaml? I feel like I'm missing something. If anything I suspect v2.00.0 Beta 8 would have caused the issue (or perhaps something going wrong with metadata), subsequent updates didn't touch the language code.

prklx2 commented 1 year ago

Here are the files:

Sony - PlayStation (Redump).txt user-config.txt

It seems that the issue was with me upgrading straight from beta 6 to 2.00.0. I cleaned up the folder and reinstalled - now everything works as it should.

unexpectedpanda commented 1 year ago

Looks like you had the system language override on, but it's identical to the global override. Beta 6 did have an issue with system languages not working. Good to hear a clean start fixed it, although I don't know how it could hold onto that issue when overwriting with 2.00.0 :/ Maybe if you're using the Python version and somehow one of the changed files wasn't overwritten, but otherwise, I'm stumped.

I'll close this up for now, but it's definitely something for me to keep an eye on, thanks for the heads up.