unexpectedpanda / retool

Retool: a better filter tool for Redump and No-Intro DAT files.
BSD 3-Clause "New" or "Revised" License
355 stars 23 forks source link

Unlicensed Games Being Excluded Even When Unchecked #257

Closed espiox closed 1 year ago

espiox commented 1 year ago

Describe the bug I have Retool configured to include Unlicensed games in Global Settings (I have no per-system overrides turned on), but for at least some systems they're being excluded anyway.

To reproduce Run Retool against the latest Game Boy and/or Game Boy Color DATs with Unlicensed unchecked in Exclusions tab.

Expected behavior Unlicensed games included in DAT.

Operating system Windows 11

Retool edition retool-gui.exe

Retool version 2.00.1

Are you using custom global or system filters? If so, list them below

Global excludes: Add-ons Applications Audio BIOS Coverdiscs Demos etc Manuals Promotional Video

Global includes: Bad dumps Bonus discs Educational MIA Multimedia Pirate Preproduction Unlicensed

System excludes: [none]

System includes: [none]

What other settings are you using? Prefer licensed versions over unlicensed, aftermarket or homebrew titles

unexpectedpanda commented 1 year ago

Unchecking an exclude is not the same as forcing those title types to be included. The checkbox solely determines whether or not a title type is excluded.

As such, the unlicensed titles in this case are still subject to 1G1R selection (meaning things like lower versions can be removed), and can potentially be replaced where licensed equivalents exist (and it looks like you've selected that option).

Do you have examples of the specific titles that were excluded?

unexpectedpanda commented 1 year ago

Concerning to hear every unlicensed title was removed.

I'm going to guess closing the issue means you figured it out though and things are operating as expected.

Let me know if you hit roadblocks otherwise.

espiox commented 1 year ago

Yeah, it was something silly elsewhere in the process that was causing the problem! Appreciate your help though.